Skip to content

chore: remove legacy Intercom env fallbacks after Pylon migration - #42151

Closed
tomjose92 wants to merge 1 commit into
releasefrom
chore/remove-legacy-intercom-env-fallbacks
Closed

tomjose92 wants to merge 1 commit into
releasefrom
chore/remove-legacy-intercom-env-fallbacks

Conversation

@tomjose92

@tomjose92 tomjose92 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Description

The Intercom chat widget (widget.intercom.io) was already replaced by Pylon in #41722. This PR removes leftover Intercom environment variable fallbacks that could still treat an old APPSMITH_INTERCOM_APP_ID / REACT_APP_INTERCOM_APP_ID as a Pylon app id.

Changes:

  • Drop Intercom app-id / disable-env fallbacks from index.html and client configs
  • Remove legacy Intercom note from app/client/.env.example
  • Align Playwright CI dummy env with APPSMITH_PYLON_APP_ID (matching other CI workflows)

Out of scope: renaming IntercomConsent / isIntercomConsentGiven (those still gate Pylon consent UX/API).

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Test plan

  • Confirm grep finds no APPSMITH_INTERCOM / REACT_APP_INTERCOM / DISABLE_INTERCOM / widget.intercom
  • With only APPSMITH_PYLON_APP_ID set, Pylon stub/boot still works
  • With only legacy Intercom env vars set (and no Pylon vars), chat widget no longer activates

Made with Cursor

Summary by CodeRabbit

  • Bug Fixes
    • Updated customer support chat configuration to use the Pylon application ID exclusively.
    • Removed legacy Intercom configuration fallbacks and environment variable guidance.
    • Improved air-gapped deployment messaging to reference third-party chat restrictions.

Intercom widget loading is already gone; drop leftover INTERCOM env aliases that could still map an old Intercom app id into Pylon.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tomjose92
tomjose92 requested a review from a team as a code owner August 20, 2026 07:40
@github-actions github-actions Bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Aug 20, 2026
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f3af521f-b119-43e8-9557-963bc0972428

📥 Commits

Reviewing files that changed from the base of the PR and between 5c89c11 and 9677caf.

📒 Files selected for processing (4)
  • .github/workflows/ci-test-playwright.yml
  • app/client/.env.example
  • app/client/public/index.html
  • app/client/src/ce/configs/index.ts
💤 Files with no reviewable changes (1)
  • app/client/.env.example

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

The change removes legacy Intercom environment variable fallbacks from Pylon configuration and updates the Playwright CI workflow to pass the Pylon app ID variable.

Changes

Pylon configuration

Layer / File(s) Summary
Pylon environment variable migration
.github/workflows/ci-test-playwright.yml, app/client/public/index.html, app/client/src/ce/configs/index.ts
Pylon configuration now uses Pylon-specific environment variables. Legacy Intercom fallbacks and guidance were removed. Playwright CI passes APPSMITH_PYLON_APP_ID.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 9677c

This change removes obsolete Intercom environment fallbacks and aligns Playwright CI with the Pylon app ID without introducing a known user-facing or production risk. No actionable merge-blocking risk remains beyond normal checks.

Suggested reviewers: salevine, subrata71, wyattwalter

Poem

Pylon lights the way,
Old Intercom paths fade,
CI carries the key,
Configs speak clearly,
Clean signals flow today.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the removal of legacy Intercom environment fallbacks after the Pylon migration.
Description check ✅ Passed The description explains the motivation, scope, changes, testing plan, automation, and communication impact; an issue reference is not included.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-legacy-intercom-env-fallbacks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tomjose92
tomjose92 requested a review from salevine August 20, 2026 07:45
@tomjose92 tomjose92 closed this Aug 20, 2026
@tomjose92
tomjose92 deleted the chore/remove-legacy-intercom-env-fallbacks branch August 20, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant